Commit a783c962 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: allow rtc_read_alarm without read_alarm callback 



.read_alarm is not necessary to read the current alarm because it is
recorded in the aie_timer and so rtc_read_alarm() will never call
rtc_read_alarm_internal() which is the only function calling the callback.

Reported-by: default avatarZhipeng Wang <zhipeng.wang_1@nxp.com>
Reported-by: default avatarMarcel Ziswiler <marcel.ziswiler@toradex.com>
Fixes: 7ae41220 ("rtc: introduce features bitfield")
Tested-by: default avatarPhilippe Schenker <philippe.schenker@toradex.com>
Link: https://lore.kernel.org/r/20230214222754.582582-1-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 2d433e9c

drivers/rtc/interface.c

+1 −1
Original line number Diff line number Diff line
@@ -392,7 +392,7 @@ int rtc_read_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) 
		return err;

	if (!rtc->ops) {

		err = -ENODEV;

	} else if (!test_bit(RTC_FEATURE_ALARM, rtc->features) || !rtc->ops->read_alarm) {

	} else if (!test_bit(RTC_FEATURE_ALARM, rtc->features)) {

		err = -EINVAL;

	} else {

		memset(alarm, 0, sizeof(struct rtc_wkalrm));