Unverified Commit a7c54b2b authored by Petr Pavlu's avatar Petr Pavlu Committed by Daniel Gomez
Browse files

tracing: Replace MAX_PARAM_PREFIX_LEN with MODULE_NAME_LEN 



Use the MODULE_NAME_LEN definition in module_exists() to obtain the maximum
size of a module name, instead of using MAX_PARAM_PREFIX_LEN. The values
are the same but MODULE_NAME_LEN is more appropriate in this context.
MAX_PARAM_PREFIX_LEN was added in commit 730b69d2 ("module: check
kernel param length at compile time, not runtime") only to break a circular
dependency between module.h and moduleparam.h, and should mostly be limited
to use in moduleparam.h.

Signed-off-by: default avatarPetr Pavlu <petr.pavlu@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: default avatarDaniel Gomez <da.gomez@samsung.com>
Acked-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
Link: https://lore.kernel.org/r/20250630143535.267745-5-petr.pavlu@suse.com


Signed-off-by: default avatarDaniel Gomez <da.gomez@samsung.com>
parent bdc877ba

kernel/trace/trace.c

+1 −1
Original line number Diff line number Diff line
@@ -10367,7 +10367,7 @@ bool module_exists(const char *module) 
{

	/* All modules have the symbol __this_module */

	static const char this_mod[] = "__this_module";

	char modname[MAX_PARAM_PREFIX_LEN + sizeof(this_mod) + 2];

	char modname[MODULE_NAME_LEN + sizeof(this_mod) + 2];

	unsigned long val;

	int n;