Unverified Commit a7cf1da7 authored by Hongling Zeng's avatar Hongling Zeng Committed by Christian Brauner
Browse files

fs: Fix return in jfs_mkdir and orangefs_mkdir 



Return NULL instead of passing to ERR_PTR while err is zero
Fixes these smatch warnings:
  - fs/jfs/namei.c:311 jfs_mkdir() warn: passing zero to 'ERR_PTR'
  - fs/orangefs/namei.c:369 orangefs_mkdir() warn: passing zero
    to 'ERR_PTR'

Fixes: 88d5baf6 ("Change inode_operations.mkdir to return struct dentry *")
Signed-off-by: default avatarHongling Zeng <zenghongling@kylinos.cn>
Link: https://patch.msgid.link/20260501071058.1243245-1-zenghongling@kylinos.cn


Reviewed-by: default avatarJori Koolstra <jkoolstra@xs4all.nl>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent a3bf0f28

fs/jfs/namei.c

+1 −1
Original line number Diff line number Diff line
@@ -309,7 +309,7 @@ static struct dentry *jfs_mkdir(struct mnt_idmap *idmap, struct inode *dip, 
      out1:



	jfs_info("jfs_mkdir: rc:%d", rc);

	return ERR_PTR(rc);

	return rc ? ERR_PTR(rc) : NULL;

}



/*

fs/orangefs/namei.c

+1 −1
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ static struct dentry *orangefs_mkdir(struct mnt_idmap *idmap, struct inode *dir, 
	__orangefs_setattr(dir, &iattr);

out:

	op_release(new_op);

	return ERR_PTR(ret);

	return ret ? ERR_PTR(ret) : NULL;

}



static int orangefs_rename(struct mnt_idmap *idmap,