Commit a838e5dc authored by Kemeng Shi's avatar Kemeng Shi Committed by Jan Kara
Browse files

quota: remove unneeded return value of register_quota_format 

The register_quota_format always returns 0, simply remove unneeded return
value.

Link: https://patch.msgid.link/20240715130534.2112678-3-shikemeng@huaweicloud.com


Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarJoseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent d16a5f85

fs/ocfs2/super.c

+2 −4
Original line number Diff line number Diff line
@@ -1571,15 +1571,13 @@ static int __init ocfs2_init(void) 


	ocfs2_set_locking_protocol();



	status = register_quota_format(&ocfs2_quota_format);

	if (status < 0)

		goto out3;

	register_quota_format(&ocfs2_quota_format);



	status = register_filesystem(&ocfs2_fs_type);

	if (!status)

		return 0;



	unregister_quota_format(&ocfs2_quota_format);

out3:

	debugfs_remove(ocfs2_debugfs_root);

	ocfs2_free_mem_caches();

out2:

fs/quota/dquot.c

+1 −2
Original line number Diff line number Diff line
@@ -163,13 +163,12 @@ static struct quota_module_name module_names[] = INIT_QUOTA_MODULE_NAMES; 
/* SLAB cache for dquot structures */

static struct kmem_cache *dquot_cachep;



int register_quota_format(struct quota_format_type *fmt)

void register_quota_format(struct quota_format_type *fmt)

{

	spin_lock(&dq_list_lock);

	fmt->qf_next = quota_formats;

	quota_formats = fmt;

	spin_unlock(&dq_list_lock);

	return 0;

}

EXPORT_SYMBOL(register_quota_format);

fs/quota/quota_v1.c

+2 −1
Original line number Diff line number Diff line
@@ -235,7 +235,8 @@ static struct quota_format_type v1_quota_format = { 


static int __init init_v1_quota_format(void)

{

        return register_quota_format(&v1_quota_format);

	register_quota_format(&v1_quota_format);

	return 0;

}



static void __exit exit_v1_quota_format(void)

fs/quota/quota_v2.c

+3 −6
Original line number Diff line number Diff line
@@ -440,12 +440,9 @@ static struct quota_format_type v2r1_quota_format = { 


static int __init init_v2_quota_format(void)

{

	int ret;



	ret = register_quota_format(&v2r0_quota_format);

	if (ret)

		return ret;

	return register_quota_format(&v2r1_quota_format);

	register_quota_format(&v2r0_quota_format);

	register_quota_format(&v2r1_quota_format);

	return 0;

}



static void __exit exit_v2_quota_format(void)

include/linux/quota.h

+1 −1
Original line number Diff line number Diff line
@@ -526,7 +526,7 @@ struct quota_info { 
	const struct quota_format_ops *ops[MAXQUOTAS];	/* Operations for each type */

};



int register_quota_format(struct quota_format_type *fmt);

void register_quota_format(struct quota_format_type *fmt);

void unregister_quota_format(struct quota_format_type *fmt);



struct quota_module_name {