Commit a846505a authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Chun-Kuang Hu
Browse files

drm/mediatek: Fix device node reference leak in mtk_dp_dt_parse() 



The function mtk_dp_dt_parse() calls of_graph_get_endpoint_by_regs()
to get the endpoint device node, but fails to call of_node_put() to release
the reference when the function returns. This results in a device node
reference leak.

Fix this by adding the missing of_node_put() call before returning from
the function.

Found via static analysis and code review.

Fixes: f70ac097 ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarMarkus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20251029072307.10955-1-linmq006@gmail.com/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent 20ac36b7

drivers/gpu/drm/mediatek/mtk_dp.c

+1 −0
Original line number Diff line number Diff line
@@ -2087,6 +2087,7 @@ static int mtk_dp_dt_parse(struct mtk_dp *mtk_dp, 
	endpoint = of_graph_get_endpoint_by_regs(pdev->dev.of_node, 1, -1);

	len = of_property_count_elems_of_size(endpoint,

					      "data-lanes", sizeof(u32));

	of_node_put(endpoint);

	if (len < 0 || len > 4 || len == 3) {

		dev_err(dev, "invalid data lane size: %d\n", len);

		return -EINVAL;