Commit a84c2a88 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM: core: Tweak pm_runtime_block_if_disabled() return value 



Modify pm_runtime_block_if_disabled() to return true when runtime PM
is disabled for the device, regardless of the power.last_status value.

This effectively prevents "smart suspend" from being enabled for
devices with runtime PM disabled in device_prepare(), even transiently,
so update the related comment in that function accordingly.

If a device has runtime PM disabled in device_prepare(), it is not
actually known whether or not runtime PM will be enabled for that
device going forward, so it is more appropriate to postpone the
"smart suspend" optimization for the device in the given system
suspend-resume cycle than to enable it and get confused going
forward.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Link: https://patch.msgid.link/13718674.uLZWGnKmhe@rjwysocki.net
parent 1476bb20

drivers/base/power/main.c

+1 −1
Original line number Diff line number Diff line
@@ -1897,7 +1897,7 @@ static int device_prepare(struct device *dev, pm_message_t state) 
		pm_runtime_put(dev);

		return ret;

	}

	/* Do not enable "smart suspend" for devices without runtime PM. */

	/* Do not enable "smart suspend" for devices with disabled runtime PM. */

	if (smart_suspend)

		smart_suspend = device_prepare_smart_suspend(dev);

drivers/base/power/runtime.c

+2 −2
Original line number Diff line number Diff line
@@ -1466,8 +1466,8 @@ bool pm_runtime_block_if_disabled(struct device *dev) 


	spin_lock_irq(&dev->power.lock);



	ret = dev->power.disable_depth && dev->power.last_status == RPM_INVALID;

	if (ret)

	ret = !pm_runtime_enabled(dev);

	if (ret && dev->power.last_status == RPM_INVALID)

		dev->power.last_status = RPM_BLOCKED;



	spin_unlock_irq(&dev->power.lock);