Commit a85c5c7a authored by Qinglang Miao's avatar Qinglang Miao Committed by Wolfram Sang
Browse files

i2c: xiic: fix reference leak when pm_runtime_get_sync fails 



The PM reference count is not expected to be incremented on
return in xiic_xfer and xiic_i2c_remove.

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 10b17004 ("i2c: xiic: Fix the clocking across bind unbind")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 2c662660

drivers/i2c/busses/i2c-xiic.c

+2 −2
Original line number Diff line number Diff line
@@ -706,7 +706,7 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) 
	dev_dbg(adap->dev.parent, "%s entry SR: 0x%x\n", __func__,

		xiic_getreg8(i2c, XIIC_SR_REG_OFFSET));



	err = pm_runtime_get_sync(i2c->dev);

	err = pm_runtime_resume_and_get(i2c->dev);

	if (err < 0)

		return err;
@@ -873,7 +873,7 @@ static int xiic_i2c_remove(struct platform_device *pdev) 
	/* remove adapter & data */

	i2c_del_adapter(&i2c->adap);



	ret = pm_runtime_get_sync(i2c->dev);

	ret = pm_runtime_resume_and_get(i2c->dev);

	if (ret < 0)

		return ret;