Commit a8655626 authored by Mikulas Patocka's avatar Mikulas Patocka
Browse files

dm-raid: don't set io_min and io_opt for raid1 



These commands
 modprobe brd rd_size=1048576
 vgcreate vg /dev/ram*
 lvcreate -m4 -L10 -n lv vg
trigger the following warnings:
device-mapper: table: 252:10: adding target device (start sect 0 len 24576) caused an alignment inconsistency
device-mapper: table: 252:10: adding target device (start sect 0 len 24576) caused an alignment inconsistency

The warnings are caused by the fact that io_min is 512 and physical block
size is 4096.

If there's chunk-less raid, such as raid1, io_min shouldn't be set to zero
because it would be raised to 512 and it would trigger the warning.

Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Cc: stable@vger.kernel.org
parent 77b8e6fb

drivers/md/dm-raid.c

+4 −2
Original line number Diff line number Diff line
@@ -3813,9 +3813,11 @@ static void raid_io_hints(struct dm_target *ti, struct queue_limits *limits) 
	struct raid_set *rs = ti->private;

	unsigned int chunk_size_bytes = to_bytes(rs->md.chunk_sectors);



	if (chunk_size_bytes) {

		limits->io_min = chunk_size_bytes;

		limits->io_opt = chunk_size_bytes * mddev_data_stripes(rs);

	}

}



static void raid_presuspend(struct dm_target *ti)

{