Commit a892b700 authored by Jaroslav Kysela's avatar Jaroslav Kysela Committed by Takashi Iwai
Browse files

ALSA: pcm: Fix id copying in snd_pcm_set_sync_per_card() 



Avoid to use strncpy and do proper length limiting (12 bytes)
to avoid out of array access.

Fixes: d712c58c ("ALSA: pcm: optimize and clarify stream synchronization ID API")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407050501.o5Z3bibi-lkp@intel.com/


Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
Link: https://patch.msgid.link/20240705075828.19746-1-perex@perex.cz


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent bc7540b7

sound/core/pcm_lib.c

+2 −2
Original line number Diff line number Diff line
@@ -543,8 +543,8 @@ void snd_pcm_set_sync_per_card(struct snd_pcm_substream *substream, 
			       const unsigned char *id, unsigned int len)

{

	*(__u32 *)params->sync = cpu_to_le32(substream->pcm->card->number);

	len = max(12, len);

	strncpy(params->sync + 4, id, len);

	len = min(12, len);

	memcpy(params->sync + 4, id, len);

	memset(params->sync + 4 + len, 0, 12 - len);

}

EXPORT_SYMBOL_GPL(snd_pcm_set_sync_per_card);