Commit a89e5890 authored Jul 04, 2024 by John Hubbard Committed by Shuah Khan Jul 11, 2024

selftests/x86: avoid -no-pie warnings from clang during compilation



When building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang warns that -no-pie is "unused during compilation".

This occurs because clang only wants to see -no-pie during linking.
Here, we don't have a separate linking stage, so a compiler warning is
unavoidable without (wastefully) restructuring the Makefile.

Avoid the warning by simply disabling that warning, for clang builds.

Acked-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

parent 2ab9c93d

tools/testing/selftests/x86/Makefile

+7 −0

Original line number	Diff line number	Diff line
		@@ -40,6 +40,13 @@ CFLAGS := -O2 -g -std=gnu99 -pthread -Wall $(KHDR_INCLUDES)
		# call32_from_64 in thunks.S uses absolute addresses.
		ifeq ($(CAN_BUILD_WITH_NOPIE),1)
		CFLAGS += -no-pie

		ifneq ($(LLVM),)
		# clang only wants to see -no-pie during linking. Here, we don't have a separate
		# linking stage, so a compiler warning is unavoidable without (wastefully)
		# restructuring the Makefile. Avoid this by simply disabling that warning.
		CFLAGS += -Wno-unused-command-line-argument
		endif
		endif

		define gen-target-rule-32