Commit a8aebe93 authored by Corey Minyard's avatar Corey Minyard
Browse files

ipmi:ssif: NULL thread on error 

Cleanup code was checking the thread for NULL, but it was possibly
a PTR_ERR() in one spot.

Spotted with static analysis.

Link: https://sourceforge.net/p/openipmi/mailman/message/59324676/


Fixes: 75c486cb ("ipmi:ssif: Clean up kthread on errors")
Cc: <stable@vger.kernel.org> # 91eb7ec7: ipmi:ssif: Remove unnecessary indention
Cc: stable@vger.kernel.org
Signed-off-by: default avatarCorey Minyard <corey@minyard.net>
parent 09dd7982

drivers/char/ipmi/ipmi_ssif.c

+1 −0
Original line number Diff line number Diff line
@@ -1905,6 +1905,7 @@ static int ssif_probe(struct i2c_client *client) 
					"kssif%4.4x", thread_num);

	if (IS_ERR(ssif_info->thread)) {

		rv = PTR_ERR(ssif_info->thread);

		ssif_info->thread = NULL;

		dev_notice(&ssif_info->client->dev,

			   "Could not start kernel thread: error %d\n",

			   rv);