Commit a8b79b09 authored by Mario Limonciello's avatar Mario Limonciello Committed by Alex Deucher
Browse files

drm/amd: Re-enable common modes for eDP and LVDS 



[Why]
Although compositors will add their own modes, Xorg won't use it's own
modes and will only stick to modes advertised by the driver. This mean a
user that used to pick 1024x768 could no longer access it unless the
panel's native resolution was 1024x768.

[How]
Revert commit 6d396e7a ("drm/amd/display: Disable common modes for
LVDS") and commit 7948afb4 ("drm/amd/display: Disable common modes
for eDP").

The panel will still use scaling for any non-native modes due to
commit 978fa2f6 ("drm/amd/display: Use scaling for non-native
resolutions on eDP")

Reported-by: default avatarMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4538


Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Link: https://lore.kernel.org/r/20250828140856.2887993-1-superm1@kernel.org


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
(cherry picked from commit c2fbf72f)
parent 5171848b

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+1 −2
Original line number Diff line number Diff line
@@ -8381,8 +8381,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector) 
				drm_add_modes_noedid(connector, 1920, 1080);

	} else {

		amdgpu_dm_connector_ddc_get_modes(connector, drm_edid);

		if (encoder && (connector->connector_type != DRM_MODE_CONNECTOR_eDP) &&

		    (connector->connector_type != DRM_MODE_CONNECTOR_LVDS))

		if (encoder)

			amdgpu_dm_connector_add_common_modes(encoder, connector);

		amdgpu_dm_connector_add_freesync_modes(connector, drm_edid);

	}