Commit a8fce7c8 authored by Paulo Alcantara's avatar Paulo Alcantara Committed by Steve French
Browse files

smb: client: improve error message when creating SMB session 



When failing to create a new SMB session with 'sec=krb5' for example,
the following error message isn't very useful

	CIFS: VFS: \\srv Send error in SessSetup = -126

Improve it by printing the following instead on dmesg

	CIFS: VFS: \\srv failed to create a new SMB session with Kerberos: -126

Signed-off-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.org>
Cc: Pierguido Lambri <plambri@redhat.com>
Reviewed-by: default avatarDavid Howells <dhowells@redhat.com>
Cc: linux-cifs@vger.kernel.org
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 855982a5

fs/smb/client/connect.c

+6 −1
Original line number Diff line number Diff line
@@ -4238,8 +4238,10 @@ cifs_setup_session(const unsigned int xid, struct cifs_ses *ses, 
	struct sockaddr_in6 *addr6 = (struct sockaddr_in6 *)&pserver->dstaddr;

	struct sockaddr_in *addr = (struct sockaddr_in *)&pserver->dstaddr;

	bool is_binding = false;

	bool new_ses;



	spin_lock(&ses->ses_lock);

	new_ses = ses->ses_status == SES_NEW;

	cifs_dbg(FYI, "%s: channel connect bitmap: 0x%lx\n",

		 __func__, ses->chans_need_reconnect);
@@ -4325,7 +4327,10 @@ cifs_setup_session(const unsigned int xid, struct cifs_ses *ses, 
	}



	if (rc) {

		cifs_server_dbg(VFS, "Send error in SessSetup = %d\n", rc);

		if (new_ses) {

			cifs_server_dbg(VFS, "failed to create a new SMB session with %s: %d\n",

					get_security_type_str(ses->sectype), rc);

		}

		spin_lock(&ses->ses_lock);

		if (ses->ses_status == SES_IN_SETUP)

			ses->ses_status = SES_NEED_RECON;