Commit a90326c7 authored by Ira Weiny's avatar Ira Weiny Committed by Dave Jiang
Browse files

cxl/region: Refactor common create region code 



create_pmem_region_store() and create_ram_region_store() are identical
with the exception of the region mode.  With the addition of DC region
mode this would end up being 3 copies of the same code.

Refactor create_pmem_region_store() and create_ram_region_store() to use
a single common function to be used in subsequent DC code.

Suggested-by: default avatarFan Ni <fan.ni@samsung.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarFan Ni <fan.ni@samsung.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarLi Ming <ming4.li@intel.com>
Reviewed-by: default avatarAlison Schofield <alison.schofield@intel.com>
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20241107-dcd-type2-upstream-v7-6-56a84e66bc36@intel.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 27fcfb41

drivers/cxl/core/region.c

+11 −17
Original line number Diff line number Diff line
@@ -2536,9 +2536,8 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd, 
	return devm_cxl_add_region(cxlrd, id, mode, CXL_DECODER_HOSTONLYMEM);

}



static ssize_t create_pmem_region_store(struct device *dev,

					struct device_attribute *attr,

					const char *buf, size_t len)

static ssize_t create_region_store(struct device *dev, const char *buf,

				   size_t len, enum cxl_decoder_mode mode)

{

	struct cxl_root_decoder *cxlrd = to_cxl_root_decoder(dev);

	struct cxl_region *cxlr;
@@ -2548,31 +2547,26 @@ static ssize_t create_pmem_region_store(struct device *dev, 
	if (rc != 1)

		return -EINVAL;



	cxlr = __create_region(cxlrd, CXL_DECODER_PMEM, id);

	cxlr = __create_region(cxlrd, mode, id);

	if (IS_ERR(cxlr))

		return PTR_ERR(cxlr);



	return len;

}



static ssize_t create_pmem_region_store(struct device *dev,

					struct device_attribute *attr,

					const char *buf, size_t len)

{

	return create_region_store(dev, buf, len, CXL_DECODER_PMEM);

}

DEVICE_ATTR_RW(create_pmem_region);



static ssize_t create_ram_region_store(struct device *dev,

				       struct device_attribute *attr,

				       const char *buf, size_t len)

{

	struct cxl_root_decoder *cxlrd = to_cxl_root_decoder(dev);

	struct cxl_region *cxlr;

	int rc, id;



	rc = sscanf(buf, "region%d\n", &id);

	if (rc != 1)

		return -EINVAL;



	cxlr = __create_region(cxlrd, CXL_DECODER_RAM, id);

	if (IS_ERR(cxlr))

		return PTR_ERR(cxlr);



	return len;

	return create_region_store(dev, buf, len, CXL_DECODER_RAM);

}

DEVICE_ATTR_RW(create_ram_region);