Unverified Commit a90903c2 authored by Haotian Zhang's avatar Haotian Zhang Committed by Mark Brown
Browse files

spi: amlogic-spifc-a1: Handle devm_pm_runtime_enable() errors 



devm_pm_runtime_enable() can fail due to memory allocation. The current
code ignores its return value, potentially causing runtime PM operations
to fail silently after autosuspend configuration.

Check the return value of devm_pm_runtime_enable() and return on failure.

Fixes: 909fac05 ("spi: add support for Amlogic A1 SPI Flash Controller")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251124015852.937-1-vulab@iscas.ac.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9f0c21ba

drivers/spi/spi-amlogic-spifc-a1.c

+3 −1
Original line number Diff line number Diff line
@@ -353,7 +353,9 @@ static int amlogic_spifc_a1_probe(struct platform_device *pdev) 


	pm_runtime_set_autosuspend_delay(spifc->dev, 500);

	pm_runtime_use_autosuspend(spifc->dev);

	devm_pm_runtime_enable(spifc->dev);

	ret = devm_pm_runtime_enable(spifc->dev);

	if (ret)

		return ret;



	ctrl->num_chipselect = 1;

	ctrl->dev.of_node = pdev->dev.of_node;