Commit a9294d86 authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: target: core: Move t_task_cdb initialization 

Prepare to split target_submit_cmd_map_sgls() so the initialization and
submission part can be called at different times. If the init part fails we
can reference the t_task_cdb early in some of the logging and tracing
code. Move it to transport_init_se_cmd() so we don't hit NULL pointer
crashes.

Link: https://lore.kernel.org/r/20210227170006.5077-2-michael.christie@oracle.com


Tested-by: default avatarLaurence Oberman <loberman@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 020b0f0a

drivers/target/target_core_transport.c

+1 −1
Original line number Diff line number Diff line
@@ -1391,6 +1391,7 @@ void transport_init_se_cmd( 
	INIT_WORK(&cmd->work, NULL);

	kref_init(&cmd->cmd_kref);



	cmd->t_task_cdb = &cmd->__t_task_cdb[0];

	cmd->se_tfo = tfo;

	cmd->se_sess = se_sess;

	cmd->data_length = data_length;
@@ -1432,7 +1433,6 @@ target_cmd_init_cdb(struct se_cmd *cmd, unsigned char *cdb) 
{

	sense_reason_t ret;



	cmd->t_task_cdb = &cmd->__t_task_cdb[0];

	/*

	 * Ensure that the received CDB is less than the max (252 + 8) bytes

	 * for VARIABLE_LENGTH_CMD