Commit a92fbeac authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/cache: Release GID table even if leak is detected 

When the table is released, we nullify pointer to GID table, it means
that in case GID entry leak is detected, we will leak table too.

Delete code that prevents table destruction.

Fixes: b150c386 ("IB/core: Introduce GID entry reference counts")
Link: https://lore.kernel.org/r/a62560af06ba82c88ef9194982bfa63d14768ff9.1716900410.git.leon@kernel.org


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent b7161db2

drivers/infiniband/core/cache.c

+5 −9
Original line number Diff line number Diff line
@@ -794,7 +794,6 @@ static struct ib_gid_table *alloc_gid_table(int sz) 
static void release_gid_table(struct ib_device *device,

			      struct ib_gid_table *table)

{

	bool leak = false;

	int i;



	if (!table)
@@ -803,15 +802,12 @@ static void release_gid_table(struct ib_device *device, 
	for (i = 0; i < table->sz; i++) {

		if (is_gid_entry_free(table->data_vec[i]))

			continue;

		if (kref_read(&table->data_vec[i]->kref) > 1) {

			dev_err(&device->dev,

				"GID entry ref leak for index %d ref=%u\n", i,



		WARN_ONCE(true,

			  "GID entry ref leak for dev %s index %d ref=%u\n",

			  dev_name(&device->dev), i,

			  kref_read(&table->data_vec[i]->kref));

			leak = true;

		}

	}

	if (leak)

		return;



	mutex_destroy(&table->lock);

	kfree(table->data_vec);