Commit a92fd2d9 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: mac80211: send DelBA with correct BSSID 



In MLO, the deflink BSSID is clearly invalid. Since we fill
the addresses as MLD addresses and translate later, use the
AP address here instead.

This fixes an issue that happens with HW restart, where the
DelBA frame is transmitted, but not processed correctly due
to the wrong BSSID (or even just discarded entirely).  As a
result, the BA sessions are kept alive; however, as other
state is reset during HW restart, this then fails (reorder,
etc.) and data doesn't go through until new BA sessions are
established.

Reviewed-by: default avatarMiriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240510112601.f4e1effdea29.I98e81f22166b68d4b6211191bcaaf8531b324a77@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 609c12a2

net/mac80211/ht.c

+1 −1
Original line number Diff line number Diff line
@@ -475,7 +475,7 @@ void ieee80211_send_delba(struct ieee80211_sub_if_data *sdata, 
	    sdata->vif.type == NL80211_IFTYPE_MESH_POINT)

		memcpy(mgmt->bssid, sdata->vif.addr, ETH_ALEN);

	else if (sdata->vif.type == NL80211_IFTYPE_STATION)

		memcpy(mgmt->bssid, sdata->deflink.u.mgd.bssid, ETH_ALEN);

		memcpy(mgmt->bssid, sdata->vif.cfg.ap_addr, ETH_ALEN);

	else if (sdata->vif.type == NL80211_IFTYPE_ADHOC)

		memcpy(mgmt->bssid, sdata->u.ibss.bssid, ETH_ALEN);