Commit a937ee6d authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: mpc8xxx: use generic device_is_compatible() 



This driver doesn't need to include of.h and use OF-specific interfaces.
Use generic property helpers instead.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20241009162910.33477-2-brgl@bgdev.pl


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 2707a028

drivers/gpio/gpio-mpc8xxx.c

+3 −5
Original line number Diff line number Diff line
@@ -15,7 +15,6 @@ 
#include <linux/irq.h>

#include <linux/kernel.h>

#include <linux/mod_devicetable.h>

#include <linux/of.h>

#include <linux/platform_device.h>

#include <linux/pm.h>

#include <linux/pm_runtime.h>
@@ -301,7 +300,6 @@ static const struct of_device_id mpc8xxx_gpio_ids[] = { 
static int mpc8xxx_probe(struct platform_device *pdev)

{

	const struct mpc8xxx_gpio_devtype *devtype = NULL;

	struct device_node *np = pdev->dev.of_node;

	struct mpc8xxx_gpio_chip *mpc8xxx_gc;

	struct device *dev = &pdev->dev;

	struct fwnode_handle *fwnode;
@@ -368,9 +366,9 @@ static int mpc8xxx_probe(struct platform_device *pdev) 
	 * the port value to the GPIO Data Register.

	 */

	fwnode = dev_fwnode(dev);

	if (of_device_is_compatible(np, "fsl,qoriq-gpio") ||

	    of_device_is_compatible(np, "fsl,ls1028a-gpio") ||

	    of_device_is_compatible(np, "fsl,ls1088a-gpio") ||

	if (device_is_compatible(dev, "fsl,qoriq-gpio") ||

	    device_is_compatible(dev, "fsl,ls1028a-gpio") ||

	    device_is_compatible(dev, "fsl,ls1088a-gpio") ||

	    is_acpi_node(fwnode)) {

		gc->write_reg(mpc8xxx_gc->regs + GPIO_IBE, 0xffffffff);

		/* Also, latch state of GPIOs configured as output by bootloader. */