Unverified Commit a93f089c authored by Fabio Estevam's avatar Fabio Estevam Committed by Mark Brown
Browse files

spi: spi-imx: Switch to RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS() 



Replace SET_RUNTIME_PM_OPS()/SET SYSTEM_SLEEP_PM_OPS() with their modern
RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS() alternatives.

The combined usage of pm_ptr() and RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS()
allows the compiler to evaluate if the runtime suspend/resume() functions
are used at build time or are simply dead code.

This allows removing the __maybe_unused notation from the runtime
suspend/resume() functions.

Signed-off-by: default avatarFabio Estevam <festevam@denx.de>
Link: https://patch.msgid.link/20240625002023.228235-1-festevam@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 17436001

drivers/spi/spi-imx.c

+6 −7
Original line number Diff line number Diff line
@@ -1898,7 +1898,7 @@ static void spi_imx_remove(struct platform_device *pdev) 
	spi_imx_sdma_exit(spi_imx);

}



static int __maybe_unused spi_imx_runtime_resume(struct device *dev)

static int spi_imx_runtime_resume(struct device *dev)

{

	struct spi_controller *controller = dev_get_drvdata(dev);

	struct spi_imx_data *spi_imx;
@@ -1919,7 +1919,7 @@ static int __maybe_unused spi_imx_runtime_resume(struct device *dev) 
	return 0;

}



static int __maybe_unused spi_imx_runtime_suspend(struct device *dev)

static int spi_imx_runtime_suspend(struct device *dev)

{

	struct spi_controller *controller = dev_get_drvdata(dev);

	struct spi_imx_data *spi_imx;
@@ -1932,22 +1932,21 @@ static int __maybe_unused spi_imx_runtime_suspend(struct device *dev) 
	return 0;

}



static int __maybe_unused spi_imx_suspend(struct device *dev)

static int spi_imx_suspend(struct device *dev)

{

	pinctrl_pm_select_sleep_state(dev);

	return 0;

}



static int __maybe_unused spi_imx_resume(struct device *dev)

static int spi_imx_resume(struct device *dev)

{

	pinctrl_pm_select_default_state(dev);

	return 0;

}



static const struct dev_pm_ops imx_spi_pm = {

	SET_RUNTIME_PM_OPS(spi_imx_runtime_suspend,

				spi_imx_runtime_resume, NULL)

	SET_SYSTEM_SLEEP_PM_OPS(spi_imx_suspend, spi_imx_resume)

	RUNTIME_PM_OPS(spi_imx_runtime_suspend,	spi_imx_runtime_resume, NULL)

	SYSTEM_SLEEP_PM_OPS(spi_imx_suspend, spi_imx_resume)

};



static struct platform_driver spi_imx_driver = {