Commit a94ff8e5 authored by Javier Carrasco's avatar Javier Carrasco Committed by Guenter Roeck
Browse files

hwmon: (ltc2992) Fix memory leak in ltc2992_parse_dt() 



A new error path was added to the fwnode_for_each_available_node() loop
in ltc2992_parse_dt(), which leads to an early return that requires a
call to fwnode_handle_put() to avoid a memory leak in that case.

Add the missing fwnode_handle_put() in the error path from a zero value
shunt resistor.

Cc: stable@vger.kernel.org
Fixes: 10b02902 ("hwmon: (ltc2992) Avoid division by zero")
Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240523-fwnode_for_each_available_child_node_scoped-v2-1-701f3a03f2fb@gmail.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent fa0bc8f2

drivers/hwmon/ltc2992.c

+3 −1
Original line number Diff line number Diff line
@@ -876,9 +876,11 @@ static int ltc2992_parse_dt(struct ltc2992_state *st) 


		ret = fwnode_property_read_u32(child, "shunt-resistor-micro-ohms", &val);

		if (!ret) {

			if (!val)

			if (!val) {

				fwnode_handle_put(child);

				return dev_err_probe(&st->client->dev, -EINVAL,

						     "shunt resistor value cannot be zero\n");

			}

			st->r_sense_uohm[addr] = val;

		}

	}