Commit a9a91799 authored by Even Xu's avatar Even Xu Committed by Benjamin Tissoires
Browse files

HID: Intel-thc-hid: Intel-thc: Add safety check for reading DMA buffer 



Add DMA buffer readiness check before reading DMA buffer to avoid
unexpected NULL pointer accessing.

Signed-off-by: default avatarEven Xu <even.xu@intel.com>
Tested-by: default avatarRui Zhang <rui1.zhang@intel.com>
Signed-off-by: default avatarBenjamin Tissoires <bentiss@kernel.org>
parent dd76788f

drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c

+5 −0
Original line number Diff line number Diff line
@@ -575,6 +575,11 @@ static int read_dma_buffer(struct thc_device *dev, 
		return -EINVAL;

	}



	if (!read_config->prd_tbls || !read_config->sgls[prd_table_index]) {

		dev_err_once(dev->dev, "PRD tables are not ready yet\n");

		return -EINVAL;

	}



	prd_tbl = &read_config->prd_tbls[prd_table_index];

	mes_len = calc_message_len(prd_tbl, &nent);

	if (mes_len > read_config->max_packet_size) {