Commit a9ce09b1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Andrew Morton
Browse files

mm/damon/tests/sysfs-kunit: fix use after free on error path 

Re-order these frees to avoid dereferencing "sysfs_target" after it has
been freed.

Link: https://lkml.kernel.org/r/aSBq5uSPIqsqH8zO@stanley.mountain


Fixes: ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 348ced3d

mm/damon/tests/sysfs-kunit.h

+1 −1
Original line number Diff line number Diff line
@@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *test) 
	if (!ctx) {

		kfree(sysfs_targets->targets_arr);

		kfree(sysfs_targets);

		kfree(sysfs_target);

		kfree(sysfs_target->regions);

		kfree(sysfs_target);

		kunit_skip(test, "ctx alloc fail");

	}