Commit aa96fbd6 authored by D. Wythe's avatar D. Wythe Committed by David S. Miller
Browse files

net/smc: put sk reference if close work was canceled 



Note that we always hold a reference to sock when attempting
to submit close_work. Therefore, if we have successfully
canceled close_work from pending, we MUST release that reference
to avoid potential leaks.

Fixes: 42bfba9e ("net/smc: immediate termination for SMCD link groups")
Signed-off-by: default avatarD. Wythe <alibuda@linux.alibaba.com>
Reviewed-by: default avatarDust Li <dust.li@linux.alibaba.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c5bf605b

net/smc/smc_close.c

+2 −1
Original line number Diff line number Diff line
@@ -116,7 +116,8 @@ static void smc_close_cancel_work(struct smc_sock *smc) 
	struct sock *sk = &smc->sk;



	release_sock(sk);

	cancel_work_sync(&smc->conn.close_work);

	if (cancel_work_sync(&smc->conn.close_work))

		sock_put(sk);

	cancel_delayed_work_sync(&smc->conn.tx_work);

	lock_sock(sk);

}