Commit aaa55faa authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: seq: ump: Fix seq port updates per FB info notify 

update_port_infos() is called when a UMP FB Info update notification
is received, and this function is supposed to update the attributes of
the corresponding sequencer port.  However, the function had a few
issues and it brought to the incorrect states.  Namely:

- It tried to get a wrong sequencer info for the update without
  correcting the port number with the group-offset 1
- The loop exited immediately when a sequencer port isn't present;
  this ended up with the truncation if a sequencer port in the middle
  goes away

This patch addresses those bugs.

Fixes: 4a16a3af ("ALSA: seq: ump: Handle FB info update")
Link: https://patch.msgid.link/20241128170423.23351-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 2e5bf5b6

sound/core/seq/seq_ump_client.c

+3 −3
Original line number Diff line number Diff line
@@ -257,12 +257,12 @@ static void update_port_infos(struct seq_ump_client *client) 
			continue;



		old->addr.client = client->seq_client;

		old->addr.port = i;

		old->addr.port = ump_group_to_seq_port(i);

		err = snd_seq_kernel_client_ctl(client->seq_client,

						SNDRV_SEQ_IOCTL_GET_PORT_INFO,

						old);

		if (err < 0)

			return;

			continue;

		fill_port_info(new, client, &client->ump->groups[i]);

		if (old->capability == new->capability &&

		    !strcmp(old->name, new->name))
@@ -271,7 +271,7 @@ static void update_port_infos(struct seq_ump_client *client) 
						SNDRV_SEQ_IOCTL_SET_PORT_INFO,

						new);

		if (err < 0)

			return;

			continue;

		/* notify to system port */

		snd_seq_system_client_ev_port_change(client->seq_client, i);

	}