Commit aaf2b248 authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

enic: fix incorrect MTU comparison in enic_change_mtu() 



The comparison in enic_change_mtu() incorrectly used the current
netdev->mtu instead of the new new_mtu value when warning about
an MTU exceeding the port MTU. This could suppress valid warnings
or issue incorrect ones.

Fix the condition and log to properly reflect the new_mtu.

Fixes: ab123fe0 ("enic: handle mtu change for vf properly")
Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Acked-by: default avatarJohn Daley <johndale@cisco.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250628145612.476096-1-alok.a.tiwari@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 42fd432f

drivers/net/ethernet/cisco/enic/enic_main.c

+2 −2
Original line number Diff line number Diff line
@@ -1864,10 +1864,10 @@ static int enic_change_mtu(struct net_device *netdev, int new_mtu) 
	if (enic_is_dynamic(enic) || enic_is_sriov_vf(enic))

		return -EOPNOTSUPP;



	if (netdev->mtu > enic->port_mtu)

	if (new_mtu > enic->port_mtu)

		netdev_warn(netdev,

			    "interface MTU (%d) set higher than port MTU (%d)\n",

			    netdev->mtu, enic->port_mtu);

			    new_mtu, enic->port_mtu);



	return _enic_change_mtu(netdev, new_mtu);

}