Commit ab3e0041 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (pmbus/core) Request threaded interrupt with IRQF_ONESHOT 



0-day rightfully complains:

drivers/hwmon/pmbus/pmbus_core.c:3164:7-32: WARNING:
	Threaded IRQ with no primary handler requested without IRQF_ONESHOT
	(unless it is nested IRQ)

Without IRQF_ONESHOT, the primary interrupt may end up in a loop,
and the threaded interrupt handler may never execute. Request interrupt
with IRQF_ONESHOT and assume that the interrupt will cleared and re-enabled
by clearing the fault condition in the threaded interrupt handler.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/linux-hwmon/6436efbb.08+e+yEDqvRxvHDP%25lkp@intel.com/T/#u


Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Naresh Solanki <Naresh.Solanki@9elements.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 5dcd53e3

drivers/hwmon/pmbus/pmbus_core.c

+2 −2
Original line number Diff line number Diff line
@@ -3246,8 +3246,8 @@ static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data) 
	}



	/* Register notifiers */

	err = devm_request_threaded_irq(dev, client->irq, NULL, pmbus_fault_handler, 0,

					"pmbus-irq", data);

	err = devm_request_threaded_irq(dev, client->irq, NULL, pmbus_fault_handler,

					IRQF_ONESHOT, "pmbus-irq", data);

	if (err) {

		dev_err(dev, "failed to request an irq %d\n", err);

		return err;