Commit ab45e1f4 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

firmware: mtk-adsp-ipc: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/e2ea8abb4c30190392a86cf05cecd722d0f0b493.1703693980.git.u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 303cbf2a

drivers/firmware/mtk-adsp-ipc.c

+2 −4
Original line number Diff line number Diff line
@@ -116,7 +116,7 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev) 
	return 0;

}



static int mtk_adsp_ipc_remove(struct platform_device *pdev)

static void mtk_adsp_ipc_remove(struct platform_device *pdev)

{

	struct mtk_adsp_ipc *adsp_ipc = dev_get_drvdata(&pdev->dev);

	struct mtk_adsp_chan *adsp_chan;
@@ -126,8 +126,6 @@ static int mtk_adsp_ipc_remove(struct platform_device *pdev) 
		adsp_chan = &adsp_ipc->chans[i];

		mbox_free_channel(adsp_chan->ch);

	}



	return 0;

}



static struct platform_driver mtk_adsp_ipc_driver = {
@@ -135,7 +133,7 @@ static struct platform_driver mtk_adsp_ipc_driver = { 
		.name = "mtk-adsp-ipc",

	},

	.probe = mtk_adsp_ipc_probe,

	.remove = mtk_adsp_ipc_remove,

	.remove_new = mtk_adsp_ipc_remove,

};

builtin_platform_driver(mtk_adsp_ipc_driver);