Commit ab7a8802 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

driver core: make driver_[create|remove]_file take a const * 

The functions driver_create_file() and driver_remove_file() do not
modify the struct device_driver structure directly, so they are safe to
be marked as a constant pointer type.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Link: https://lore.kernel.org/r/2024070844-volley-hatchling-c812@gregkh


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a23b018c

drivers/base/driver.c

+2 −2
Original line number Diff line number Diff line
@@ -173,7 +173,7 @@ EXPORT_SYMBOL_GPL(driver_find_device); 
 * @drv: driver.

 * @attr: driver attribute descriptor.

 */

int driver_create_file(struct device_driver *drv,

int driver_create_file(const struct device_driver *drv,

		       const struct driver_attribute *attr)

{

	int error;
@@ -191,7 +191,7 @@ EXPORT_SYMBOL_GPL(driver_create_file); 
 * @drv: driver.

 * @attr: driver attribute descriptor.

 */

void driver_remove_file(struct device_driver *drv,

void driver_remove_file(const struct device_driver *drv,

			const struct driver_attribute *attr)

{

	if (drv)

include/linux/device/driver.h

+2 −2
Original line number Diff line number Diff line
@@ -146,9 +146,9 @@ struct driver_attribute { 
#define DRIVER_ATTR_WO(_name) \

	struct driver_attribute driver_attr_##_name = __ATTR_WO(_name)



int __must_check driver_create_file(struct device_driver *driver,

int __must_check driver_create_file(const struct device_driver *driver,

				    const struct driver_attribute *attr);

void driver_remove_file(struct device_driver *driver,

void driver_remove_file(const struct device_driver *driver,

			const struct driver_attribute *attr);



int driver_set_override(struct device *dev, const char **override,