Commit ab91c140 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

netlink: specs: remove implicit structs for SNMP counters 



uAPI doesn't define structs for the SNMP counters, just enums to index
them as arrays. Switch to the same representation in the spec. C codegen
will soon need all the struct types to actually exist.

Note that the existing definition was broken, anyway, as the first
member should be the number of counters reported.

Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Link: https://patch.msgid.link/20250506194101.696272-4-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6c242239

Documentation/netlink/specs/rt-link.yaml

+12 −48
Original line number Diff line number Diff line
@@ -585,138 +585,102 @@ definitions: 
        type: u32

  -

    name: ifla-icmp6-stats

    type: struct

    members:

    enum-name:

    type: enum

    entries:

      -

        name: num

      -

        name: inmsgs

        type: u64

      -

        name: inerrors

        type: u64

      -

        name: outmsgs

        type: u64

      -

        name: outerrors

        type: u64

      -

        name: csumerrors

        type: u64

      -

        name: ratelimithost

        type: u64

  -

    name: ifla-inet6-stats

    type: struct

    members:

    enum-name:

    type: enum

    entries:

      -

        name: num

      -

        name: inpkts

        type: u64

      -

        name: inoctets

        type: u64

      -

        name: indelivers

        type: u64

      -

        name: outforwdatagrams

        type: u64

      -

        name: outpkts

        type: u64

      -

        name: outoctets

        type: u64

      -

        name: inhdrerrors

        type: u64

      -

        name: intoobigerrors

        type: u64

      -

        name: innoroutes

        type: u64

      -

        name: inaddrerrors

        type: u64

      -

        name: inunknownprotos

        type: u64

      -

        name: intruncatedpkts

        type: u64

      -

        name: indiscards

        type: u64

      -

        name: outdiscards

        type: u64

      -

        name: outnoroutes

        type: u64

      -

        name: reasmtimeout

        type: u64

      -

        name: reasmreqds

        type: u64

      -

        name: reasmoks

        type: u64

      -

        name: reasmfails

        type: u64

      -

        name: fragoks

        type: u64

      -

        name: fragfails

        type: u64

      -

        name: fragcreates

        type: u64

      -

        name: inmcastpkts

        type: u64

      -

        name: outmcastpkts

        type: u64

      -

        name: inbcastpkts

        type: u64

      -

        name: outbcastpkts

        type: u64

      -

        name: inmcastoctets

        type: u64

      -

        name: outmcastoctets

        type: u64

      -

        name: inbcastoctets

        type: u64

      -

        name: outbcastoctets

        type: u64

      -

        name: csumerrors

        type: u64

      -

        name: noectpkts

        type: u64

      -

        name: ect1-pkts

        type: u64

      -

        name: ect0-pkts

        type: u64

      -

        name: cepkts

        type: u64

      -

        name: reasm-overlaps

        type: u64

  - name: br-boolopt-multi

    type: struct

    members:
@@ -2195,7 +2159,7 @@ attribute-sets: 
      -

        name: stats

        type: binary

        struct: ifla-inet6-stats

        sub-type: u64

      -

        name: mcast

        type: binary
@@ -2206,7 +2170,7 @@ attribute-sets: 
      -

        name: icmp6stats

        type: binary

        struct: ifla-icmp6-stats

        sub-type: u64

      -

        name: token

        type: binary