Commit aba23b0a authored by Renjaya Raga Zenta's avatar Renjaya Raga Zenta Committed by Kalle Valo
Browse files

wifi: brcmfmac: fix brcmf_vif_clear_mgmt_ies when stopping AP 



This removes the following error log when stopping AP:

ieee80211 phy0: brcmf_vif_set_mgmt_ie: vndr ie set error : -52

It happened if:

1) previously wlan interface was in station mode (wpa_supplicant) and
   connected to a hotspot
2) then started AP mode (hostapd)
3) and then stopped AP mode.

The error happened when it tried to clear BRCMF_VNDR_IE_PRBREQ_FLAG.
This flag is not set in `brcmf_config_ap_mgmt_ie`, but
BRCMF_VNDR_IE_ASSOCRSP_FLAG is set instead.

Signed-off-by: default avatarRenjaya Raga Zenta <ragazenta@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241121-brcmfmac-v1-1-02fc3fb427c2@gmail.com
parent 01e767d6

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

+5 −1
Original line number Diff line number Diff line
@@ -4999,12 +4999,16 @@ s32 brcmf_vif_set_mgmt_ie(struct brcmf_cfg80211_vif *vif, s32 pktflag, 
s32 brcmf_vif_clear_mgmt_ies(struct brcmf_cfg80211_vif *vif)

{

	static const s32 pktflags[] = {

		BRCMF_VNDR_IE_PRBREQ_FLAG,

		BRCMF_VNDR_IE_PRBRSP_FLAG,

		BRCMF_VNDR_IE_BEACON_FLAG

	};

	int i;



	if (vif->wdev.iftype == NL80211_IFTYPE_AP)

		brcmf_vif_set_mgmt_ie(vif, BRCMF_VNDR_IE_ASSOCRSP_FLAG, NULL, 0);

	else

		brcmf_vif_set_mgmt_ie(vif, BRCMF_VNDR_IE_PRBREQ_FLAG, NULL, 0);



	for (i = 0; i < ARRAY_SIZE(pktflags); i++)

		brcmf_vif_set_mgmt_ie(vif, pktflags[i], NULL, 0);