Commit abda0af4 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: container: Use acpi_dev_for_each_child() 



Instead of walking the list of children of an ACPI device directly,
use acpi_dev_for_each_child() to carry out an action for all of
the given ACPI device's children.

This will help to eliminate the children list head from struct
acpi_device as it is redundant and it is used in questionable ways
in some places (in particular, locking is needed for walking the
list pointed to it safely, but it is often missing).

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent bf5fb8ae

drivers/acpi/container.c

+9 −8
Original line number Diff line number Diff line
@@ -23,17 +23,18 @@ static const struct acpi_device_id container_device_ids[] = { 


#ifdef CONFIG_ACPI_CONTAINER



static int acpi_container_offline(struct container_dev *cdev)

static int check_offline(struct acpi_device *adev, void *not_used)

{

	struct acpi_device *adev = ACPI_COMPANION(&cdev->dev);

	struct acpi_device *child;

	if (acpi_scan_is_offline(adev, false))

		return 0;



	/* Check all of the dependent devices' physical companions. */

	list_for_each_entry(child, &adev->children, node)

		if (!acpi_scan_is_offline(child, false))

	return -EBUSY;

}



	return 0;

static int acpi_container_offline(struct container_dev *cdev)

{

	/* Check all of the dependent devices' physical companions. */

	return acpi_dev_for_each_child(ACPI_COMPANION(&cdev->dev), check_offline, NULL);

}



static void acpi_container_release(struct device *dev)