Commit abe3817f authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpio: 74x164: Fully convert to use managed resources 



Convert the driver probe stage to use managed resources.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250207151825.2122419-6-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent e742e6b0

drivers/gpio/gpio-74x164.c

+16 −11
Original line number Diff line number Diff line
@@ -95,6 +95,19 @@ static int gen_74x164_direction_output(struct gpio_chip *gc, 
	return 0;

}



static void gen_74x164_deactivate(void *data)

{

	struct gen_74x164_chip *chip = data;



	gpiod_set_value_cansleep(chip->gpiod_oe, 0);

}



static int gen_74x164_activate(struct device *dev, struct gen_74x164_chip *chip)

{

	gpiod_set_value_cansleep(chip->gpiod_oe, 1);

	return devm_add_action_or_reset(dev, gen_74x164_deactivate, chip);

}



static int gen_74x164_probe(struct spi_device *spi)

{

	struct device *dev = &spi->dev;
@@ -128,8 +141,6 @@ static int gen_74x164_probe(struct spi_device *spi) 
	if (IS_ERR(chip->gpiod_oe))

		return PTR_ERR(chip->gpiod_oe);



	spi_set_drvdata(spi, chip);



	chip->gpio_chip.label = spi->modalias;

	chip->gpio_chip.direction_output = gen_74x164_direction_output;

	chip->gpio_chip.get = gen_74x164_get_value;
@@ -149,18 +160,13 @@ static int gen_74x164_probe(struct spi_device *spi) 
	if (ret)

		return dev_err_probe(&spi->dev, ret, "Config write failed\n");



	gpiod_set_value_cansleep(chip->gpiod_oe, 1);

	ret = gen_74x164_activate(dev, chip);

	if (ret)

		return ret;



	return devm_gpiochip_add_data(&spi->dev, &chip->gpio_chip, chip);

}



static void gen_74x164_remove(struct spi_device *spi)

{

	struct gen_74x164_chip *chip = spi_get_drvdata(spi);



	gpiod_set_value_cansleep(chip->gpiod_oe, 0);

}



static const struct spi_device_id gen_74x164_spi_ids[] = {

	{ .name = "74hc595" },

	{ .name = "74lvc594" },
@@ -181,7 +187,6 @@ static struct spi_driver gen_74x164_driver = { 
		.of_match_table	= gen_74x164_dt_ids,

	},

	.probe		= gen_74x164_probe,

	.remove		= gen_74x164_remove,

	.id_table	= gen_74x164_spi_ids,

};

module_spi_driver(gen_74x164_driver);