Commit abff279e authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: remove the refcount warning/check at btrfs_put_delayed_ref() 



At btrfs_put_delayed_ref(), it's pointless to have a WARN_ON() to check if
the refcount of the delayed ref is zero. Such check is already done by the
refcount_t module and refcount_dec_and_test(), which loudly complains if
we try to decrement a reference count that is currently 0.

The WARN_ON() dates back to the time when used a regular atomic_t type
for the reference counter, before we switched to the refcount_t type.
The main goal of the refcount_t type/module is precisely to catch such
types of bugs and loudly complain if they happen.

This also reduces a bit the module's text size.
Before this change:

   $ size fs/btrfs/btrfs.ko
      text	   data	    bss	    dec	    hex	filename
   1612483	 167145	  16864	1796492	 1b698c	fs/btrfs/btrfs.ko

After this change:

   $ size fs/btrfs/btrfs.ko
      text	   data	    bss	    dec	    hex	filename
   1612371	 167073	  16864	1796308	 1b68d4	fs/btrfs/btrfs.ko

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 3cbb9f51

fs/btrfs/delayed-ref.h

+0 −1
Original line number Diff line number Diff line
@@ -344,7 +344,6 @@ btrfs_free_delayed_extent_op(struct btrfs_delayed_extent_op *op) 


static inline void btrfs_put_delayed_ref(struct btrfs_delayed_ref_node *ref)

{

	WARN_ON(refcount_read(&ref->refs) == 0);

	if (refcount_dec_and_test(&ref->refs)) {

		WARN_ON(!RB_EMPTY_NODE(&ref->ref_node));

		switch (ref->type) {