Commit ac1d9770 authored by Nirjhar Roy (IBM)'s avatar Nirjhar Roy (IBM) Committed by Carlos Maiolino
Browse files

xfs: Add a comment in xfs_log_sb() 



Add a comment explaining why the sb_frextents are updated outside the
if (xfs_has_lazycount(mp) check even though it is a lazycounter.
RT groups are supported only in v5 filesystems which always have
lazycounter enabled - so putting it inside the if(xfs_has_lazycount(mp)
check is redundant.

Suggested-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarNirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent 8baa9bcc

fs/xfs/libxfs/xfs_sb.c

+3 −0
Original line number Diff line number Diff line
@@ -1347,6 +1347,9 @@ xfs_log_sb( 
	 * feature was introduced.  This counter can go negative due to the way

	 * we handle nearly-lockless reservations, so we must use the _positive

	 * variant here to avoid writing out nonsense frextents.

	 *

	 * RT groups are only supported on v5 file systems, which always

	 * have lazy SB counters.

	 */

	if (xfs_has_rtgroups(mp) && !xfs_has_zoned(mp)) {

		mp->m_sb.sb_frextents =