Commit ac1ff574 authored by Illia Barbashyn's avatar Illia Barbashyn Committed by Takashi Iwai
Browse files

ALSA: hda/realtek - Enable mute LEDs on HP ENVY x360 15-es0xxx 



The mute and mic-mute LEDs on HP ENVY x360 Convertible 15-es0xxx
(PCI SSID 103c:88b3) do not work with the current driver.

This model requires a combination of COEFBIT and GPIO fixups to
correctly control the LEDs. Introduce a new fixup function
alc245_fixup_hp_envy_x360_mute_led and add a quirk to apply it.

Signed-off-by: default avatarIllia Barbashyn <04baril@gmail.com>
Link: https://patch.msgid.link/20260207221955.24132-1-04baril@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1585cf83

sound/hda/codecs/realtek/alc269.c

+13 −0
Original line number Diff line number Diff line
@@ -1660,6 +1660,13 @@ static void alc285_fixup_hp_spectre_x360_mute_led(struct hda_codec *codec, 
	alc285_fixup_hp_gpio_micmute_led(codec, fix, action);

}



static void alc245_fixup_hp_envy_x360_mute_led(struct hda_codec *codec,

				const struct hda_fixup *fix, int action)

{

	alc245_fixup_hp_mute_led_v1_coefbit(codec, fix, action);

	alc245_fixup_hp_gpio_led(codec, fix, action);

}



static void alc236_fixup_hp_mute_led(struct hda_codec *codec,

				const struct hda_fixup *fix, int action)

{
@@ -3908,6 +3915,7 @@ enum { 
	ALC285_FIXUP_HP_GPIO_LED,

	ALC285_FIXUP_HP_MUTE_LED,

	ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED,

	ALC245_FIXUP_HP_ENVY_X360_MUTE_LED,

	ALC285_FIXUP_HP_BEEP_MICMUTE_LED,

	ALC236_FIXUP_HP_MUTE_LED_COEFBIT2,

	ALC236_FIXUP_HP_GPIO_LED,
@@ -5546,6 +5554,10 @@ static const struct hda_fixup alc269_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_spectre_x360_mute_led,

	},

	[ALC245_FIXUP_HP_ENVY_X360_MUTE_LED] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc245_fixup_hp_envy_x360_mute_led,

	},

	[ALC285_FIXUP_HP_BEEP_MICMUTE_LED] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_beep,
@@ -6814,6 +6826,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x8895, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),

	SND_PCI_QUIRK(0x103c, 0x88b3, "HP ENVY x360 Convertible 15-es0xxx", ALC245_FIXUP_HP_ENVY_X360_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x88dd, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x88eb, "HP Victus 16-e0xxx", ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT),