Commit ac24f6cd authored by Donet Tom's avatar Donet Tom Committed by Andrew Morton
Browse files

drivers/base/node: remove register_memory_blocks_under_node() function call from register_one_node 

register_one_node() is now only called via cpu_up() →
__try_online_node() during CPU hotplug operations to online a node.

At this stage, the node has not yet had any memory added.  As a result,
there are no memory blocks to walk or register, so calling
register_memory_blocks_under_node() is unnecessary.

Therefore, the call to register_memory_blocks_under_node() has been
removed from register_one_node().

Link: https://lkml.kernel.org/r/ecf07075b1a41015fcf58823997d5c2ed7b8c18f.1748452242.git.donettom@linux.ibm.com


Signed-off-by: default avatarDonet Tom <donettom@linux.ibm.com>
Acked-by: default avatarOscar Salvador <osalvador@suse.de>
Acked-by: default avatarMike Rapoport (Microsoft) <rppt@kernel.org>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 69e944b1

include/linux/node.h

+1 −15
Original line number Diff line number Diff line
@@ -134,21 +134,7 @@ extern int __register_one_node(int nid); 
/* Registers an online node */

static inline int register_one_node(int nid)

{

	int error = 0;



	if (node_online(nid)) {

		struct pglist_data *pgdat = NODE_DATA(nid);

		unsigned long start_pfn = pgdat->node_start_pfn;

		unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages;



		error = __register_one_node(nid);

		if (error)

			return error;

		register_memory_blocks_under_node(nid, start_pfn, end_pfn,

						  MEMINIT_EARLY);

	}



	return error;

	return __register_one_node(nid);

}



extern void unregister_one_node(int nid);