Commit ac2fbe09 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Borislav Petkov (AMD)
Browse files

EDAC/igen6: Constify struct res_config 



The res_config structs are not modified in this driver.

Constifying these structures moves some data to a read-only section, so
increase overall security, especially when the structure holds some function
pointers.

On a x86_64, with allmodconfig, as an example:

  Before:
  ======
     text	   data	    bss	    dec	    hex	filename
    36777	   2479	   4304	  43560	   aa28	drivers/edac/igen6_edac.o

  After:
  =====
     text	   data	    bss	    dec	    hex	filename
    37297	   1959	   4304	  43560	   aa28	drivers/edac/igen6_edac.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Link: https://lore.kernel.org/r/a06153870951a64b438e76adf97d440e02c1a1fc.1738355198.git.christophe.jaillet@wanadoo.fr
parent 12378e1c

drivers/edac/igen6_edac.c

+10 −10
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ 
#define MEM_SLICE_HASH_MASK(v)		(GET_BITFIELD(v, 6, 19) << 6)

#define MEM_SLICE_HASH_LSB_MASK_BIT(v)	GET_BITFIELD(v, 24, 26)



static struct res_config {

static const struct res_config {

	bool machine_check;

	int num_imc;

	u32 imc_base;
@@ -472,7 +472,7 @@ static u64 rpl_p_err_addr(u64 ecclog) 
	return ECC_ERROR_LOG_ADDR45(ecclog);

}



static struct res_config ehl_cfg = {

static const struct res_config ehl_cfg = {

	.num_imc		= 1,

	.imc_base		= 0x5000,

	.ibecc_base		= 0xdc00,
@@ -482,7 +482,7 @@ static struct res_config ehl_cfg = { 
	.err_addr_to_imc_addr	= ehl_err_addr_to_imc_addr,

};



static struct res_config icl_cfg = {

static const struct res_config icl_cfg = {

	.num_imc		= 1,

	.imc_base		= 0x5000,

	.ibecc_base		= 0xd800,
@@ -492,7 +492,7 @@ static struct res_config icl_cfg = { 
	.err_addr_to_imc_addr	= ehl_err_addr_to_imc_addr,

};



static struct res_config tgl_cfg = {

static const struct res_config tgl_cfg = {

	.machine_check		= true,

	.num_imc		= 2,

	.imc_base		= 0x5000,
@@ -506,7 +506,7 @@ static struct res_config tgl_cfg = { 
	.err_addr_to_imc_addr	= tgl_err_addr_to_imc_addr,

};



static struct res_config adl_cfg = {

static const struct res_config adl_cfg = {

	.machine_check		= true,

	.num_imc		= 2,

	.imc_base		= 0xd800,
@@ -517,7 +517,7 @@ static struct res_config adl_cfg = { 
	.err_addr_to_imc_addr	= adl_err_addr_to_imc_addr,

};



static struct res_config adl_n_cfg = {

static const struct res_config adl_n_cfg = {

	.machine_check		= true,

	.num_imc		= 1,

	.imc_base		= 0xd800,
@@ -528,7 +528,7 @@ static struct res_config adl_n_cfg = { 
	.err_addr_to_imc_addr	= adl_err_addr_to_imc_addr,

};



static struct res_config rpl_p_cfg = {

static const struct res_config rpl_p_cfg = {

	.machine_check		= true,

	.num_imc		= 2,

	.imc_base		= 0xd800,
@@ -540,7 +540,7 @@ static struct res_config rpl_p_cfg = { 
	.err_addr_to_imc_addr	= adl_err_addr_to_imc_addr,

};



static struct res_config mtl_ps_cfg = {

static const struct res_config mtl_ps_cfg = {

	.machine_check		= true,

	.num_imc		= 2,

	.imc_base		= 0xd800,
@@ -551,7 +551,7 @@ static struct res_config mtl_ps_cfg = { 
	.err_addr_to_imc_addr	= adl_err_addr_to_imc_addr,

};



static struct res_config mtl_p_cfg = {

static const struct res_config mtl_p_cfg = {

	.machine_check		= true,

	.num_imc		= 2,

	.imc_base		= 0xd800,
@@ -1374,7 +1374,7 @@ static void unregister_err_handler(void) 
	unregister_nmi_handler(NMI_SERR, IGEN6_NMI_NAME);

}



static void opstate_set(struct res_config *cfg, const struct pci_device_id *ent)

static void opstate_set(const struct res_config *cfg, const struct pci_device_id *ent)

{

	/*

	 * Quirk: Certain SoCs' error reporting interrupts don't work.