Commit ac553418 authored by Jakob Koschel's avatar Jakob Koschel Committed by Greg Kroah-Hartman
Browse files

usb: gadget: pxa27x_udc: replace usage of rc to check if a list element was found 

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable [1].

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/


Signed-off-by: default avatarJakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220308171818.384491-23-jakobkoschel@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eb6dc99e

drivers/usb/gadget/udc/pxa27x_udc.c

+7 −6
Original line number Diff line number Diff line
@@ -1159,7 +1159,7 @@ static int pxa_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) 
{

	struct pxa_ep		*ep;

	struct udc_usb_ep	*udc_usb_ep;

	struct pxa27x_request	*req;

	struct pxa27x_request	*req = NULL, *iter;

	unsigned long		flags;

	int			rc = -EINVAL;
@@ -1173,12 +1173,13 @@ static int pxa_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) 
	spin_lock_irqsave(&ep->lock, flags);



	/* make sure it's actually queued on this endpoint */

	list_for_each_entry(req, &ep->queue, queue) {

		if (&req->req == _req) {

	list_for_each_entry(iter, &ep->queue, queue) {

		if (&iter->req != _req)

			continue;

		req = iter;

		rc = 0;

		break;

	}

	}



	spin_unlock_irqrestore(&ep->lock, flags);

	if (!rc)