Commit ac62f521 authored May 26, 2024 by Thomas Weißschuh Committed by Rafael J. Wysocki May 28, 2024

ACPI: AC: Properly notify powermanagement core about changes

The powermanagement core does various actions when a powersupply changes.
It calls into notifiers, LED triggers, other power supplies and emits an uevent.

To make sure that all these actions happen properly call power_supply_changed().

Reported-by: Rajas Paranjpe <paranjperajas@gmail.com>
Closes: https://github.com/MrChromebox/firmware/issues/420#issuecomment-2132251318

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 1613e604

drivers/acpi/ac.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -145,7 +145,7 @@ static void acpi_ac_notify(acpi_handle handle, u32 event, void *data)
		dev_name(&adev->dev), event,
		(u32) ac->state);
		acpi_notifier_call_chain(adev, event, (u32) ac->state);
		kobject_uevent(&ac->charger->dev.kobj, KOBJ_CHANGE);
		power_supply_changed(ac->charger);
		}
		}

		@@ -268,7 +268,7 @@ static int acpi_ac_resume(struct device *dev)
		if (acpi_ac_get_state(ac))
		return 0;
		if (old_state != ac->state)
		kobject_uevent(&ac->charger->dev.kobj, KOBJ_CHANGE);
		power_supply_changed(ac->charger);

		return 0;
		}

drivers/acpi/sbs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -610,7 +610,7 @@ static void acpi_sbs_callback(void *context)
		if (sbs->charger_exists) {
		acpi_ac_get_present(sbs);
		if (sbs->charger_present != saved_charger_state)
		kobject_uevent(&sbs->charger->dev.kobj, KOBJ_CHANGE);
		power_supply_changed(sbs->charger);
		}

		if (sbs->manager_present) {
		@@ -622,7 +622,7 @@ static void acpi_sbs_callback(void *context)
		acpi_battery_read(bat);
		if (saved_battery_state == bat->present)
		continue;
		kobject_uevent(&bat->bat->dev.kobj, KOBJ_CHANGE);
		power_supply_changed(bat->bat);
		}
		}
		}