Commit ac72ad9d authored May 09, 2025 by Dikshita Agarwal Committed by Hans Verkuil Jul 03, 2025

media: iris: Add handling for no show frames



Firmware sends the picture type as NO_SHOW for frames which are not
supposed to be displayed, add handling for the same in driver to drop
them.

Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # on sa8775p-ride
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

parent b791dcfc

drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -113,6 +113,7 @@ enum hfi_picture_type {
		HFI_PICTURE_I = 0x00000008,
		HFI_PICTURE_CRA = 0x00000010,
		HFI_PICTURE_BLA = 0x00000020,
		HFI_PICTURE_NOSHOW = 0x00000040,
		};

		enum hfi_buffer_type {

drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -91,7 +91,9 @@ static int iris_hfi_gen2_get_driver_buffer_flags(struct iris_inst *inst, u32 hfi
		struct iris_inst_hfi_gen2 *inst_hfi_gen2 = to_iris_inst_hfi_gen2(inst);
		u32 driver_flags = 0;

		if (inst_hfi_gen2->hfi_frame_info.picture_type & keyframe)
		if (inst_hfi_gen2->hfi_frame_info.picture_type & HFI_PICTURE_NOSHOW)
		driver_flags \|= V4L2_BUF_FLAG_ERROR;
		else if (inst_hfi_gen2->hfi_frame_info.picture_type & keyframe)
		driver_flags \|= V4L2_BUF_FLAG_KEYFRAME;
		else if (inst_hfi_gen2->hfi_frame_info.picture_type & HFI_PICTURE_P)
		driver_flags \|= V4L2_BUF_FLAG_PFRAME;