Commit ac753e1f authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Greg Kroah-Hartman
Browse files

tty: atmel_serial: Use of_property_present() for non-boolean properties 



The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.

As of_property_present() returns a boolean, use that directly
and simplify the code a bit while we're here.

Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Acked-by: default avatarRichard Genoud <richard.genoud@bootlin.com>
Reviewed-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20250109182053.3970547-1-robh@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 104c1b9d

drivers/tty/serial/atmel_serial.c

+4 −14
Original line number Diff line number Diff line
@@ -1727,26 +1727,16 @@ static void atmel_init_property(struct atmel_uart_port *atmel_port, 


	/* DMA/PDC usage specification */

	if (of_property_read_bool(np, "atmel,use-dma-rx")) {

		if (of_property_read_bool(np, "dmas")) {

			atmel_port->use_dma_rx  = true;

			atmel_port->use_pdc_rx  = false;

		} else {

			atmel_port->use_dma_rx  = false;

			atmel_port->use_pdc_rx  = true;

		}

		atmel_port->use_dma_rx = of_property_present(np, "dmas");

		atmel_port->use_pdc_rx = !atmel_port->use_dma_rx;

	} else {

		atmel_port->use_dma_rx  = false;

		atmel_port->use_pdc_rx  = false;

	}



	if (of_property_read_bool(np, "atmel,use-dma-tx")) {

		if (of_property_read_bool(np, "dmas")) {

			atmel_port->use_dma_tx  = true;

			atmel_port->use_pdc_tx  = false;

		} else {

			atmel_port->use_dma_tx  = false;

			atmel_port->use_pdc_tx  = true;

		}

		atmel_port->use_dma_tx = of_property_present(np, "dmas");

		atmel_port->use_pdc_tx = !atmel_port->use_dma_tx;

	} else {

		atmel_port->use_dma_tx  = false;

		atmel_port->use_pdc_tx  = false;