Commit ac7c48c0 authored by Philip Yang's avatar Philip Yang Committed by Alex Deucher
Browse files

drm/amdkfd: Don't take process mutex for svm ioctls 



SVM ioctls take proper svms->lock to handle race conditions, don't need
take process mutex to serialize ioctls. This also fixes circular locking
warning:

WARNING: possible circular locking dependency detected

  Possible unsafe locking scenario:

        CPU0                    CPU1
        ----                    ----
   lock((work_completion)(&svms->deferred_list_work));
                                lock(&process->mutex);
                     lock((work_completion)(&svms->deferred_list_work));
   lock(&process->mutex);

   *** DEADLOCK ***

Signed-off-by: default avatarPhilip Yang <Philip.Yang@amd.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b6dca949

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

+0 −4
Original line number Diff line number Diff line
@@ -1847,13 +1847,9 @@ static int kfd_ioctl_svm(struct file *filep, struct kfd_process *p, void *data) 
	if (!args->start_addr || !args->size)

		return -EINVAL;



	mutex_lock(&p->mutex);



	r = svm_ioctl(p, args->op, args->start_addr, args->size, args->nattr,

		      args->attrs);



	mutex_unlock(&p->mutex);



	return r;

}

#else