Commit ac8082a3 authored by Aya Levin's avatar Aya Levin Committed by Saeed Mahameed
Browse files

net/mlx5: Fix fw reporter diagnose output 



Restore fw reporter diagnose to print the syndrome even if it is zero.
Following the cited commit, in this case (syndrome == 0) command returns no
output at all.

This fix restores command output in case syndrome is cleared:
$ devlink health diagnose pci/0000:82:00.0 reporter fw
    Syndrome: 0

Fixes: d17f98bf ("net/mlx5: devlink health: use retained error fmsg API")
Signed-off-by: default avatarAya Levin <ayal@nvidia.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 85ea2c5c

drivers/net/ethernet/mellanox/mlx5/core/health.c

+1 −1
Original line number Diff line number Diff line
@@ -452,10 +452,10 @@ mlx5_fw_reporter_diagnose(struct devlink_health_reporter *reporter, 
	struct health_buffer __iomem *h = health->health;

	u8 synd = ioread8(&h->synd);



	devlink_fmsg_u8_pair_put(fmsg, "Syndrome", synd);

	if (!synd)

		return 0;



	devlink_fmsg_u8_pair_put(fmsg, "Syndrome", synd);

	devlink_fmsg_string_pair_put(fmsg, "Description", hsynd_str(synd));



	return 0;