Commit ac8f09b9 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Jakub Kicinski
Browse files

sctp: Remove unused sctp_assoc_del_peer and sctp_chunk_iif 



sctp_assoc_del_peer() last use was removed in 2015 by
commit 73e67420 ("sctp: Do not try to search for the transport twice")
which now uses rm_peer instead of del_peer.

sctp_chunk_iif() last use was removed in 2016 by
commit 1f45f78f ("sctp: allow GSO frags to access the chunk too")

Remove them.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Acked-by: default avatarXin Long <lucien.xin@gmail.com>
Link: https://patch.msgid.link/20250501233815.99832-1-linux@treblig.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1f586017

include/net/sctp/sm.h

+0 −1
Original line number Diff line number Diff line
@@ -161,7 +161,6 @@ const struct sctp_sm_table_entry *sctp_sm_lookup_event( 
					enum sctp_event_type event_type,

					enum sctp_state state,

					union sctp_subtype event_subtype);

int sctp_chunk_iif(const struct sctp_chunk *);

struct sctp_association *sctp_make_temp_asoc(const struct sctp_endpoint *,

					     struct sctp_chunk *,

					     gfp_t gfp);

include/net/sctp/structs.h

+0 −2
Original line number Diff line number Diff line
@@ -2152,8 +2152,6 @@ struct sctp_transport *sctp_assoc_add_peer(struct sctp_association *, 
				     const union sctp_addr *address,

				     const gfp_t gfp,

				     const int peer_state);

void sctp_assoc_del_peer(struct sctp_association *asoc,

			 const union sctp_addr *addr);

void sctp_assoc_rm_peer(struct sctp_association *asoc,

			 struct sctp_transport *peer);

void sctp_assoc_control_transport(struct sctp_association *asoc,

net/sctp/associola.c

+0 −18
Original line number Diff line number Diff line
@@ -736,24 +736,6 @@ struct sctp_transport *sctp_assoc_add_peer(struct sctp_association *asoc, 
	return peer;

}



/* Delete a transport address from an association.  */

void sctp_assoc_del_peer(struct sctp_association *asoc,

			 const union sctp_addr *addr)

{

	struct list_head	*pos;

	struct list_head	*temp;

	struct sctp_transport	*transport;



	list_for_each_safe(pos, temp, &asoc->peer.transport_addr_list) {

		transport = list_entry(pos, struct sctp_transport, transports);

		if (sctp_cmp_addr_exact(addr, &transport->ipaddr)) {

			/* Do book keeping for removing the peer and free it. */

			sctp_assoc_rm_peer(asoc, transport);

			break;

		}

	}

}



/* Lookup a transport by address. */

struct sctp_transport *sctp_assoc_lookup_paddr(

					const struct sctp_association *asoc,

net/sctp/sm_make_chunk.c

+0 −8
Original line number Diff line number Diff line
@@ -115,14 +115,6 @@ static void sctp_control_set_owner_w(struct sctp_chunk *chunk) 
	skb->destructor = sctp_control_release_owner;

}



/* What was the inbound interface for this chunk? */

int sctp_chunk_iif(const struct sctp_chunk *chunk)

{

	struct sk_buff *skb = chunk->skb;



	return SCTP_INPUT_CB(skb)->af->skb_iif(skb);

}



/* RFC 2960 3.3.2 Initiation (INIT) (1)

 *

 * Note 2: The ECN capable field is reserved for future use of