Commit acd1e47d authored by Ally Heev's avatar Ally Heev Committed by Madhavan Srinivasan
Browse files

powerpc: 82xx: fix uninitialized pointers with free attribute 



Uninitialized pointers with `__free` attribute can cause undefined
behavior as the memory allocated to the pointer is freed automatically
when the pointer goes out of scope.

powerpc/km82xx doesn't have any bugs related to this as of now, but,
it is better to initialize and assign pointers with `__free` attribute
in one statement to ensure proper scope-based cleanup

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/


Signed-off-by: default avatarAlly Heev <allyheev@gmail.com>
Fixes: 4aa5cc1e ("powerpc-km82xx.c: replace of_node_put() with __free")
Reviewed-by: default avatarChristophe Leroy (CS GROUP) <chleroy@kernel.org>
Reviewed-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20251116-aheev-uninitialized-free-attr-km82xx-v2-1-4307e2b5300d@gmail.com
parent 8d57bb61

arch/powerpc/platforms/82xx/km82xx.c

+2 −2
Original line number Diff line number Diff line
@@ -27,8 +27,8 @@ 


static void __init km82xx_pic_init(void)

{

	struct device_node *np __free(device_node);

	np = of_find_compatible_node(NULL, NULL, "fsl,pq2-pic");

	struct device_node *np __free(device_node) = of_find_compatible_node(NULL,

		NULL, "fsl,pq2-pic");



	if (!np) {

		pr_err("PIC init: can not find cpm-pic node\n");