Commit aceb04f5 authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: x86: Drop local pvclock_flags variable in kvm_guest_time_update() 



Drop the local pvclock_flags in kvm_guest_time_update(), the local variable
is immediately shoved into the per-vCPU "cache", i.e. the local variable
serves no purpose.

No functional change intended.

Reviewed-by: default avatarPaul Durrant <paul@xen.org>
Link: https://lore.kernel.org/r/20250201013827.680235-4-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 4198f38a

arch/x86/kvm/x86.c

+2 −5
Original line number Diff line number Diff line
@@ -3178,7 +3178,6 @@ static int kvm_guest_time_update(struct kvm_vcpu *v) 
	struct kvm_arch *ka = &v->kvm->arch;

	s64 kernel_ns;

	u64 tsc_timestamp, host_tsc;

	u8 pvclock_flags;

	bool use_master_clock;

#ifdef CONFIG_KVM_XEN

	/*
@@ -3261,11 +3260,9 @@ static int kvm_guest_time_update(struct kvm_vcpu *v) 
	vcpu->last_guest_tsc = tsc_timestamp;



	/* If the host uses TSC clocksource, then it is stable */

	pvclock_flags = 0;

	vcpu->hv_clock.flags = 0;

	if (use_master_clock)

		pvclock_flags |= PVCLOCK_TSC_STABLE_BIT;



	vcpu->hv_clock.flags = pvclock_flags;

		vcpu->hv_clock.flags |= PVCLOCK_TSC_STABLE_BIT;



	if (vcpu->pv_time.active)

		kvm_setup_guest_pvclock(v, &vcpu->pv_time, 0, false);