Commit acf40ab4 authored by Charles Han's avatar Charles Han Committed by Linus Walleij
Browse files

pinctrl: nuvoton: npcm8xx: Add NULL check in npcm8xx_gpio_fw 



devm_kasprintf() calls can return null pointers on failure.
But the return values were not checked in npcm8xx_gpio_fw().
Add NULL check in npcm8xx_gpio_fw(), to handle kernel NULL
pointer dereference error.

Fixes: acf4884a ("pinctrl: nuvoton: add NPCM8XX pinctrl and GPIO driver")
Signed-off-by: default avatarCharles Han <hanchunchao@inspur.com>
Link: https://lore.kernel.org/20250212100532.4317-1-hanchunchao@inspur.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 68283c1c

drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c

+3 −0
Original line number Diff line number Diff line
@@ -2374,6 +2374,9 @@ static int npcm8xx_gpio_fw(struct npcm8xx_pinctrl *pctrl) 
		pctrl->gpio_bank[id].gc.parent = dev;

		pctrl->gpio_bank[id].gc.fwnode = child;

		pctrl->gpio_bank[id].gc.label = devm_kasprintf(dev, GFP_KERNEL, "%pfw", child);

		if (pctrl->gpio_bank[id].gc.label == NULL)

			return -ENOMEM;



		pctrl->gpio_bank[id].gc.dbg_show = npcmgpio_dbg_show;

		pctrl->gpio_bank[id].direction_input = pctrl->gpio_bank[id].gc.direction_input;

		pctrl->gpio_bank[id].gc.direction_input = npcmgpio_direction_input;