Commit ad01dada authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Christian Brauner
Browse files

block: remove checks for FALLOC_FL_NO_HIDE_STALE 



While the FALLOC_FL_NO_HIDE_STALE value has been registered, it has
always been rejected by vfs_fallocate before making it into
blkdev_fallocate because it isn't in the supported mask.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240827065123.1762168-2-hch@lst.de


Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 47ac09b9

block/fops.c

+1 −9
Original line number Diff line number Diff line
@@ -771,7 +771,7 @@ static ssize_t blkdev_read_iter(struct kiocb *iocb, struct iov_iter *to) 


#define	BLKDEV_FALLOC_FL_SUPPORTED					\

		(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE |		\

		 FALLOC_FL_ZERO_RANGE | FALLOC_FL_NO_HIDE_STALE)

		 FALLOC_FL_ZERO_RANGE)



static long blkdev_fallocate(struct file *file, int mode, loff_t start,

			     loff_t len)
@@ -830,14 +830,6 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start, 
					     len >> SECTOR_SHIFT, GFP_KERNEL,

					     BLKDEV_ZERO_NOFALLBACK);

		break;

	case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:

		error = truncate_bdev_range(bdev, file_to_blk_mode(file), start, end);

		if (error)

			goto fail;



		error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT,

					     len >> SECTOR_SHIFT, GFP_KERNEL);

		break;

	default:

		error = -EOPNOTSUPP;

	}