Commit ad0ac6cd authored by Michal Luczaj's avatar Michal Luczaj Committed by Jakub Kicinski
Browse files

net: skbuff: Drop unused @skb 



Since its introduction in commit ce098da1 ("skbuff: Introduce
slab_build_skb()"), __slab_build_skb() never used the @skb argument. Remove
it and adapt both callers.

No functional change intended.

Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarMichal Luczaj <mhal@rbox.co>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 25489a4f

net/core/skbuff.c

+3 −4
Original line number Diff line number Diff line
@@ -384,8 +384,7 @@ static inline void __finalize_skb_around(struct sk_buff *skb, void *data, 
	skb_set_kcov_handle(skb, kcov_common_handle());

}



static inline void *__slab_build_skb(struct sk_buff *skb, void *data,

				     unsigned int *size)

static inline void *__slab_build_skb(void *data, unsigned int *size)

{

	void *resized;
@@ -418,7 +417,7 @@ struct sk_buff *slab_build_skb(void *data) 
		return NULL;



	memset(skb, 0, offsetof(struct sk_buff, tail));

	data = __slab_build_skb(skb, data, &size);

	data = __slab_build_skb(data, &size);

	__finalize_skb_around(skb, data, size);



	return skb;
@@ -435,7 +434,7 @@ static void __build_skb_around(struct sk_buff *skb, void *data, 
	 * using slab buffer should use slab_build_skb() instead.

	 */

	if (WARN_ONCE(size == 0, "Use slab_build_skb() instead"))

		data = __slab_build_skb(skb, data, &size);

		data = __slab_build_skb(data, &size);



	__finalize_skb_around(skb, data, size);

}